One will find below a list of changes which have been prototyped and are ready to be committed, once Calorimetry contributors all agree with it.
Status bits
Storage of data producer names instead of status bits
Starting at CalClusters level, objects are less numerous in the event (as
compared to lower level objects) and can be a little bigger. This is why,
for each data object, we would like prefer to store the producer name of the producer as a
std::string, and remove the equivalent status bits. Such a mechanism
can adapt to any change in the algorithms, and string in each CalCluster
and in each CalCorToolResult, rather than rely in status bits. Status bits
are predefined and can hardly be used with new
/user algorithms, a lot more easily than status bitsthus it
reduces flexibility.
To be removed:
- CalCluster::*CLUSTER
- CalCorToolResult::CALVALS, PROFILE, LASTLAYER, RAWENERGY
...
We should avoid status bits saying things about algorithms, because
this reduce our freedom with the way we arrange and change those
algorithms. We should prefer eventually status bits which say
things about the "state" of the data.
To be investigated removed :
- CalCluster::MIPTRACK
- CalCluster::MOMENTS
- CalCluster::ENERGYCORR
- CalCluster::MIPFIT
Generalize the validity status bits.
Is is safe to use status bits so to flag the data which is valid or not.
To be added :
- CalCluster::AXIS (instead of MOMENTS)
- CalEventEnergy::VALIDPARAMS
Etc.
It seems CalCluster::ISOLATEDCLUSTER is redundant, and equivalent
to !ALLXTALS.
...