Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Status bits

Storage of data producer names

Starting at CalClusters level, objects are not less numerous in the event (as
compared to lower level objects) and can be a little bigger. This is why,
for each data object, we woudl would like to store the name of the producer as a
std::string, and remove the equivalent status bits. Such a mechanism
can adapt to any change in the algorithms, and be used with new
user algorithms, a lot more easily than status bits.

Status bits methods

For the useful status bits (for example the ones saying if this or
that data is valid), the methods signatures could be made more
uniform in the various CalRecon classes.

Correction Tools

Kind of energy

It seems not all the tools are returning the same kind of energy.
Most of them are returning the evaluation of the total gamma energy.
We must investigate if CalValsCorrTool, which apparently returns the
cal-only energy, can be modified so to return the same as other tools,
and we must also investigate if Tkr code can be modified accordingly.

Handling of multiple clusters

Debate let us think that the tools should not process each cluster
individually, but should receive the complete list of available clusters.
They can then consider only the front/best one if they wish.

CalTransvOffsetTool

It seems it is not used. As a first step, we want to remove
it from the list of default tools. What's more, it is not computing
an energy. If we must keep it, this should certainly not
be a kind of ICalEnergyCorr.

...