Status bits
Storage of data producer names instead of status bits
Starting at CalClusters level, objects are less numerous in the event (as
compared to lower level objects) and can be a little bigger. This is why,
for each data object, we would like to store the name of the producer as a
std::string, and remove the equivalent status bits. Such a mechanism
can adapt to any change in the algorithms, and be used with new
user algorithms, a lot more easily than status bits.
Avoid algo-oriented status bits
We should avoid status bits saying things about algorithms, because
this reduce our freedom with the way we arrange and change those
algorithms. We should prefer eventually status bits which say
things about the "state" of the data.
Status bits methods
For the useful status bits (for example the ones saying if this or
that data is valid), the methods signatures could be made more
uniform in the various CalRecon classes.
Correction Tools
Kind of energy
It seems not all the tools are returning the same kind of energy.
Most of them are returning the evaluation of the total gamma energy.
We must investigate if CalValsCorrTool, which apparently returns the
cal-only energy, can be modified so to return the same as other tools,
and we must also investigate if Tkr code can be modified accordingly
(and what about CalRawEnergyTool ?).
Handling of multiple clusters
Debate let us think that the tools should not process each cluster
individually, but should receive the complete list of available clusters.
They can then consider only the front/best one if they wish.
CalTransvOffsetTool
It seems it is not used. As a first step, we want to remove
it from the list of default tools. What's more, it is not computing
an energy. If we must keep it, this should certainly not
be a kind of ICalEnergyCorr.
CalEventEnergy
No more singleton
We want to enable multiple instances of CalEventEnergy, so that
one make several differetn interpretations of the event, for
example 1 Gamma and 2 PI0. As an additionnal benefit, this will
ease the management of CalEventEnergy in the TDS and in the
ROOT trees.
CalEventEnergyAlg passes
The current implementation is more or less hard coding that there are
two passes, and select the best energy candidate depending on the pass.
We propose something more flexible : there is no information about the
pass, and the best energy candidate is selected depending on the ones
which are present in the list : energy of CalValCorrTools if it is present,
and CalRawEnergyTool otherwise.
A detail: why duplicate the data fo the best CalCorToolResult ? Why not
simply point to it ?