Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Migration of unmigrated content due to installation of a new plugin

...

 http://glast-ground.slac.stanford.edu/SystemTests/?releaseVersionId=13441

Section
bordertrue

Looking at the plots, the main thing I noticed is that the quantity CALRMSTRANS seems to be different in most tests, AG, Muons, Bkg.
I dowloaded the merit files for the allGamma, and compared the merit variable called Cal1TransRms... and they are identical, see plot attached.
I am a bit curious, where does the CALRMSTRANS variable of the systests come from ?
Is that the trans rms of each cluster (not just the first one) before
normalization by the energy, as the units suggests ?
...and why would it be different ?

For other variables in the BackGndMixDC2, the differences seem really small to me, small enough to be ignored... unless someone is willing to dig into the code obviously.

Cheers,
Johan

the CALRMSTRANS variable in the systests comes from the recon ROOT files, it is contains the value of getRmsTrans() for every CalCluster, see line 82 in CalCluster.h: http://www-glast.stanford.edu/cgi-bin/viewcvs/reconRootData/reconRootData/CalCluster.h?annotate=1.32
and this snippet from ReconCalFragment.cxx, one of the systest ROOT macros:

Code Block
borderStyledashed
TObjArray clusterCol = cRH->getCalClusterCol();
int nCalClus = clusterCol->GetEntries();
((TH1F*)GetObjectPtr("CALCLUSCOUNT"))->Fill((Float_t)nCalClus);
for (int rc=0; rc < nCalClus; rc++) {       CalCluster* c=(CalCluster*)clusterCol->At(rc);
 ((TH1F*)GetObjectPtr("CALRECESUM"))->Fill(c->getEnergySum());
 ((TH1F*)GetObjectPtr("CALRECELEAK"))->Fill(c->getEnergyLeak());
 ((TH1F*)GetObjectPtr("CALRECECORR"))->Fill(c->getEnergyCorrected());
 ((TH1F*)GetObjectPtr("CALRECEFIT"))->Fill(c->getFitEnergy());
 ((TH1F*)GetObjectPtr("CALRMSTRANS"))->Fill(c->getRmsTrans());
 blah blah     }

Where if I'm reading the code correctly, getRmsTrans is associated with an old pre-P8 variable that is left in to allow reading of older ROOT files. But in today's world - that variable isn't initialized ... not even to zero..and appears to be completely unused. One might modify the code to at least init those old variables to zero to avoid future confusion and this particular plot could be eliminated and replaced in the system tests..with something else such as the CalMomParams values - see next paragraph.

Meanwhile the merit variable Cal1TransRms is filled in AnaTup via:
CAL_Clu1_MomTransRms = calCluster->getMomParams().getTransRms(); which is going to be calculated in the CalRecon CalMomentsAnalysis code...the newer P8 stuff...and I'm happy to hear you see that the values are identical in the two runs.

Heather

Panel
bgColoryellow
titleA Final Word from Johan
borderStylesolid

I had a look at the plots again, and another couple of variables,
and I confirm that the v20r3p4-sconsEvSeed – v20r3p4-evSeed comparison looks really good.
The few remaining differences are sub-percent level and for really just a couple of quantities.

As far as I am concerned, that validates the scons release.

I'll now start to look at the RHEL4/RHEL5 comparisons.

Cheers,
Johan

RHEL5 SCons versus RHEL4 SCons builds of GlastRelease-20-03-04 

...