...
However, since steering has only recorded the extant corrector BDESes before it started its calculation, and the bump changed those values, and steering then implements its calculated change to the corrector settings assuming that
change is the change to the BDESes it recorded, the effect is to undo the BUMP.
...
Make steering set the values of corrector magnets as changes from their extant values at the time of the implementation of the orbit correction solution
(when the user actually hits TRIM or in the case of AUTO steering immediately after the calculation has been completed; GOF uses AUTO steering), rather that as changes from values acquired from the database when steering was initialized.
...
Care however must be taken not to set the BDESes to values which exceed BMAX. This condition is nominally checked in each steering method's function (It looks like STR_COR_RMS and STR_SVD), but now, since it may have changed, it has to be checked again.DB_OUT already does that at least by the brute force mechanism of binding to the bmax. That may well be all that's needed.
Testing
The following sanity checks made by steering should still work:
- trim followed by a trim with no intermediate calc, results in an err msg
- can't trim until calc completed
- untrim works
- can't untrim unless a trim has been done