Versions Compared

Old Version 2

changes.mady.by.user Maurik Holtrop

Saved on

compared with

New Version Current

changes.mady.by.user Maurik Holtrop

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  1. Retiring Test Run 2014 code                                — Kyle, Maurik, Jeremy
    1. We have unused code cluttering up readout and recon dating back to the 2014 photon runs. It seems no one is looking at this anymore, so can we retire this code?
    2. Do we create a “legacy2014” tag? The current code probably does not even work anymore, so is this useful?
  2. Plans for using Machine Learning with HPS        — Kyle
    1. Truth information needs to be propagated better.
  3. Closing Pull Requests                                         — All
  4. Quick project checking/update (time permitting)  — All
  5. Questions?            

Notes:

  • Kyle: The still contains old 2014 code. This is cluttering things up, and it is not clear if it is still working, it is probably not used. Can we retire this code?
    • Jeremy: Yes, he agrees. Before this is done, we should have better tests, to make sure that any changes are not affecting the output.
    • Omar: What is the issue?
    • Kyle: The readout code needs to change so that the hodoscope readout can be incorporated into the trigger. The ECAL and the hodoscope need to be timed correctly to make sure we can create a trigger with this. Since this requires to learn the entire readout and modifications, we may as well clean it up as well.
    • Omar: I don't think we should get rid of the code, it needs to be preserved. It works, there is still backward compatibility. 
    • Kyle: Can we make a branch? So that we do preserve this code, but now in the master we do not need... (led to a contentious discussion whether anyone would ever look at this data.)
    • We need to make a tag, that is recognizable, which allows us to go back to code that works for the Test data. Omar states that this code was way back in CVS, and those tags were lost when we switched to SVN.
    • TestrunRecon(whatever) driver still exists and is still used/important... This may need to be renamed, redone. Tricky code.
    • YES, we can go ahead and take out the test run parts of the code. We will make a tag that allow anyone to go back to a Legacy_Test_Run