GLAST Standard Analysis Environment (SAE) Evaluation Questionnaire
Science Tools Checkout 2
March 31 -  april 8, 2005

Reviewer: Razzano Massimiliano

Software Component: PulsePhase

Summary of Tests Performed:

- Tests with PulsarSpectrum simulator.
- Test with delta Dirac-shaped (single and double);
- Test with EGRET pulsars with specific TimeProfiles and comparison between original and reconstructed profile;
- Test with random generated timeprofiles;
All the tests spans period from 1 day to 1 month of data.
- No background in order to maximize the corrections due to the ephemerides avoiding confusion
   between pulsars photons and background photons.


Observations:

User Interface

 1. What, if anything, about the choice and meaning of parameters
    could be improved? Are there new parameters which need to be
    added? Are the current parameters sensible?

	Ok

 2. Are there any prompts you would suggest rewording?

	As my review in ST Checkout 1.
	Clarify the units used for epoch. We asked for that and now we know that the units 
	are the same used in the timing (seconds from start) but one can think of JD,MJD,
 	seconds. I think this should be inserted in the prompt.

 3. Are there any hidden parameters which you think should be
    prompted for or vice versa?

	Ok

 4. Would you like the prompts to appear in a different order?

	Ok  

 5. Would you suggest changes to the default values of any
    parameters? Changes to min, max fields?

	Ok

Tool Behavior

 6. In what way, if any, did the tool perform unexpectedly? 

  - In the input of the initial phase pulsePhase doesn't complain when you insert 
    values not in the range 0-1.0 of even negative values.

 7. Were there any aspects of the tool's output which seem
    scientifically suspicious to you? (e.g. fluxes too large,
    number of events selected too small, etc.)

	- The base value for phase should be between 0 and 1, 
	but when I try to insert values out of this range or negative I receive no warnings.
	Does the tool perform automatically the reduction to the first period?	See also 
	the question before. 

 8. Was there information (i.e. output) the tool did not provide
    which you think it should?

    As my review in ST checkout 1:	
    A little msg that say that the file is been processed and the phase are stored in 
    the same input file. We know that now, but an eventual user can have doubts about that.

 9. Was there information (i.e. output) the tool provided which
    you think it should not?

	Ok
	
Future Development

10. List new features you would like to see implemented, in
    descending order of importance. Please flag any which you
    think are critical for DC2.

11. Are there any aspects of this tool you would change in order
    for it to work more smoothly with other parts of the SAE?


JIRA Summary

Please list the identifiers of any/all JIRA issues which were filed
in connection with this evaluation.

	I've placed all the issues here and I will place also in JIRA. 

General Notes

	Now in this checkout I had the chance to check also the second period derivative and not 
	only the first, and also the epoch and the initial phase, so my investigation was 
	more complete respect to the 1st Checkout.